Align data migration tool with current version #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P column. Added hsql ddl. Use ddls in acceptence test.
melowe
requested review from
chris-j-h,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
prd-fox
previously requested changes
Mar 27, 2019
data-migration/src/main/java/com/quorum/tessera/data/migration/H2DataExporter.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
============================================
- Coverage 99.49% 99.49% -0.01%
- Complexity 1869 1870 +1
============================================
Files 286 287 +1
Lines 5570 5567 -3
Branches 276 275 -1
============================================
- Hits 5542 5539 -3
Misses 5 5
Partials 23 23
Continue to review full report at Codecov.
|
…e new ddl changes aren't refected in migration module.
prd-fox
approved these changes
Mar 28, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered issue where constellation data store migration tool is missing TIMESTAMP column.
Added
TIMESTAMPcolumn definition when performing the data migration, which means the created database is compliant with the latest release version.Use provided DDL scripts for acceptance tests (H2, HSQL, and sqlite) to ensure these are aligned with current code base.
Added HSQL ddl.